As a former public school student myself, let me tell you that there's nothing idiotic about the notion. There were some teachers who were truly inspirational; many who were clearly good teachers whether or not you liked their teaching style; some who clearly knew their material but didn't quite know how to best teach it; some who didn't know their material at all; and others who may have been good at teaching, and may have been knowledgeable, but I'll never know because they didn't try teaching at all. You seem to be confounding preference with competence .
Your conceit is that you believe students (except yourself, I imagine) and administrators are too stupid to separate the two, when in fact I find the majority are not. In high school, we had a biology teacher who was a strict disciplinarian who pushed hard, overloaded us with work, and was almost universally despised--yet not one of us didn't come out feeling that we learned the material far better than other students, even though not all of us would want to go through it again.
Your nutrition analogy is more appropriate than you realize. A balanced diet means a mix of all your nutritional needs--not eating the fatal all-carrot diet you describe, but having a good mix that meets all your dietary requirements. But, to use your own phrasing, it's idiotic to assume all foods are created equal, and that all teachers are foods. Students need proteins, they need carbohydrates, and they need vitamins. A healthy diet pretty much requires vegetables, grains, and some sort of meat, dairy, or beans. It does not require a hamburger once a year. And a teacher like a greasy hamburger--one that students enjoy, but basically offers empty calories, a heart attack waiting to happen, and almost as an after thought, a little bit of real nutrition--is not one you want teaching all year, any more than you'd want your kids eating hamburgers all year. And let's not forget the truth, which you've somehow been spared for fifty years, but which almost any student who's gone to an average or below average public school quickly learns: some teachers don't even meet the bare minimum as "food." Some are shredded newspapers mixed with sawdust, put into the flour as filler, and some are just lead paint chips.
The two teachers you describe might have reflected different student preferences, but they at least taught. I've had teachers who put on Jerry Springer, and have us read to ourselves from the book year--assigning homework was rare, grading it and giving it back to us rarer. I've had teachers who used their political leanings in class to inspire those who agreed with them, and to spur those who didn't into working extra hard to argue against her intelligently, but how does making obvious racial comments qualify as a "special style of teaching?" YOU might think that the teacher who makes it clear to his students that he doesn't expect the 'ghetto' blacks, Asians, and Hispanics to succeed, so he won't waste his time teaching them (had two in my HS) is simply "a cucumber" that wasn't "to my preference," but personally, I think he was an asbestos sandwich that I don't think any student should be forced to swallow. (I suppose you'll argue that to the white students and the minorities from one of the few more affluent neighborhoods, he WAS a good teacher, but as one of them let me tell you, I disagree.)
To characterize all teachers by the actions of their worst colleagues is unfair, and to accept politically motivated firings is even more so, but to deny such unambiguously bad teachers exist is idiotic, and to keep them in schools for the sake of maintaining this illusion is tauntamount to sacrificing our children's futures to make a point.
I find it most interesting that you managed to slip in the political point about encouraging unions. The statistic regarding households with union members is interesting, but I wonder, where does it come from, and how does it compare union and non-union? (i.e., does it compare jobs at a comparative pay scale, do professional organizations, such as the Society of Engineering Professionals (or equivalent) or the state bar? Also, it makes an explicit assumption that being in a union causes more stable households, when in fact you've only proven correlation (if that).
Also, while I realize that often, different students and administrators 'like' different teaching styles, dwelling on the point completely ignores the fact that often times bad teachers get into the system, and while it might be hard to right a rigid set of criteria defining a "bad teacher," identifying them and getting them out. If you're concerned this gives too much power to the judgment of one person, then give ultimate power to multiple administrators, or to a committee, one that may only include a representative of the teaching union if they don't have veto power on firings. Or institute a tiered system, where bad teachers get a second or a third chance in a new situation--a "good teacher" with an unorthodox teaching style may not have found his or her niche at first, but should be able to after a move or two.
By the way, if you're asking yourself "whether 'success in schools' is a good thing," you're probably part of the problem. The primary job of public schooling is to teach "book smarts" and maybe instill a love of learning in general; social conditioning, emotional development, education in 'common sense' are all great side effects of a good education, but that education is still the main point, and questioning it seems like a convenient way to defend an incompetant teacher.